Skip to content

[Drop-In UI] Ability to inject custom End Navigation button via Binder.#6331

Merged
cafesilencio merged 2 commits intomainfrom
tr-dropin_inject_end_navigation_button
Sep 15, 2022
Merged

[Drop-In UI] Ability to inject custom End Navigation button via Binder.#6331
cafesilencio merged 2 commits intomainfrom
tr-dropin_inject_end_navigation_button

Conversation

@tomaszrybakiewicz
Copy link
Copy Markdown
Contributor

@tomaszrybakiewicz tomaszrybakiewicz commented Sep 14, 2022

Closes #6201

Description

  • Introduced ViewBinderCustomization.infoPanelEndNavigationButtonBinder that allows injection of a custom Info Panel End Navigation Button.
  • Updated InfoPanelHeaderActiveGuidanceBinder and InfoPanelHeaderArrivalBinder layouts, and binding logic to use infoPanelEndNavigationButtonBinder.
  • Added InfoPanelEndNavigationButtonBinder that programmatically adds the End Navigation button.

Screenshots or Gifs

Recording of a QA-Test-App captured on Pixel 6

device-2022-09-14-153204.mp4

@tomaszrybakiewicz tomaszrybakiewicz added the UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. label Sep 14, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 14, 2022

Codecov Report

Merging #6331 (1d36740) into main (b7d87d2) will decrease coverage by 0.04%.
The diff coverage is 21.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #6331      +/-   ##
============================================
- Coverage     68.72%   68.68%   -0.05%     
  Complexity     4484     4484              
============================================
  Files           679      681       +2     
  Lines         26924    26948      +24     
  Branches       3155     3156       +1     
============================================
+ Hits          18503    18508       +5     
- Misses         7211     7229      +18     
- Partials       1210     1211       +1     
Impacted Files Coverage Δ
...er/infopanel/InfoPanelEndNavigationButtonBinder.kt 0.00% <0.00%> (ø)
...r/infopanel/InfoPanelHeaderActiveGuidanceBinder.kt 23.07% <0.00%> (ø)
...n/binder/infopanel/InfoPanelHeaderArrivalBinder.kt 23.07% <0.00%> (ø)
...igation/dropin/internal/NavigationViewContextEx.kt 37.50% <0.00%> (-5.36%) ⬇️
...in/internal/extensions/MapboxExtendableButtonEx.kt 0.00% <0.00%> (ø)
...in/java/com/mapbox/navigation/dropin/ViewBinder.kt 89.33% <20.00%> (-4.96%) ⬇️
...apbox/navigation/dropin/ViewBinderCustomization.kt 100.00% <100.00%> (ø)
...mapbox/navigation/dropin/ViewStyleCustomization.kt 100.00% <100.00%> (ø)

@tomaszrybakiewicz tomaszrybakiewicz marked this pull request as ready for review September 14, 2022 19:33
@tomaszrybakiewicz tomaszrybakiewicz requested a review from a team as a code owner September 14, 2022 19:33
@kmadsen
Copy link
Copy Markdown
Contributor

kmadsen commented Sep 15, 2022

Implementation all looks good to me, will let you rebase and then essentially good to go.

@tomaszrybakiewicz is there a ripple effect on the button? If not will you add one by chance? 🤌

… that allows injection of a custom Info Panel End Navigation Button.

Updated InfoPanelHeaderActiveGuidanceBinder and InfoPanelHeaderArrivalBinder layouts, and binding logic to use infoPanelEndNavigationButtonBinder.
Added InfoPanelEndNavigationButtonBinder that programmatically adds the End Navigation button.
@tomaszrybakiewicz tomaszrybakiewicz force-pushed the tr-dropin_inject_end_navigation_button branch from 0b536b7 to 1d36740 Compare September 15, 2022 20:15
@cafesilencio cafesilencio merged commit 1dc164d into main Sep 15, 2022
@cafesilencio cafesilencio deleted the tr-dropin_inject_end_navigation_button branch September 15, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android Drop-In UI : Is it possible to customize the action in end navigation(x) click

3 participants