[Drop-In UI] Ability to inject custom End Navigation button via Binder.#6331
Merged
cafesilencio merged 2 commits intomainfrom Sep 15, 2022
Merged
[Drop-In UI] Ability to inject custom End Navigation button via Binder.#6331cafesilencio merged 2 commits intomainfrom
cafesilencio merged 2 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6331 +/- ##
============================================
- Coverage 68.72% 68.68% -0.05%
Complexity 4484 4484
============================================
Files 679 681 +2
Lines 26924 26948 +24
Branches 3155 3156 +1
============================================
+ Hits 18503 18508 +5
- Misses 7211 7229 +18
- Partials 1210 1211 +1
|
Contributor
|
Implementation all looks good to me, will let you rebase and then essentially good to go. @tomaszrybakiewicz is there a ripple effect on the button? If not will you add one by chance? 🤌 |
kmadsen
approved these changes
Sep 15, 2022
… that allows injection of a custom Info Panel End Navigation Button. Updated InfoPanelHeaderActiveGuidanceBinder and InfoPanelHeaderArrivalBinder layouts, and binding logic to use infoPanelEndNavigationButtonBinder. Added InfoPanelEndNavigationButtonBinder that programmatically adds the End Navigation button.
0b536b7 to
1d36740
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6201
Description
ViewBinderCustomization.infoPanelEndNavigationButtonBinderthat allows injection of a custom Info Panel End Navigation Button.InfoPanelHeaderActiveGuidanceBinderandInfoPanelHeaderArrivalBinderlayouts, and binding logic to useinfoPanelEndNavigationButtonBinder.InfoPanelEndNavigationButtonBinderthat programmatically adds the End Navigation button.Screenshots or Gifs
Recording of a QA-Test-App captured on Pixel 6
device-2022-09-14-153204.mp4