[Drop-In UI] add ability to observe when map click was not handled by drop-in#6360
Merged
Zayankovsky merged 1 commit intomainfrom Sep 22, 2022
Merged
[Drop-In UI] add ability to observe when map click was not handled by drop-in#6360Zayankovsky merged 1 commit intomainfrom
Zayankovsky merged 1 commit intomainfrom
Conversation
Zayankovsky
added
the
UI
Zayankovsky
force-pushed
the
NAVAND-287-vz-notify-map-clicked
branch
from
c1691f7 to
264c3a7
Compare
Codecov Report
@@ Coverage Diff @@
## main #6360 +/- ##
=========================================
Coverage 68.84% 68.84%
- Complexity 4519 4523 +4
=========================================
Files 683 684 +1
Lines 27137 27150 +13
Branches 3170 3170
=========================================
+ Hits 18682 18692 +10
- Misses 7233 7237 +4
+ Partials 1222 1221 -1
|
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/binder/map/MapBinder.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/NavigationViewListenerRegistry.kt
Outdated
Show resolved
Hide resolved
Zayankovsky
force-pushed
the
NAVAND-287-vz-notify-map-clicked
branch
2 times, most recently
from
5655dd6 to
bf347da
Compare
Contributor
|
Let's add unit tests for |
Zayankovsky
force-pushed
the
NAVAND-287-vz-notify-map-clicked
branch
from
bf347da to
d2d530b
Compare
Contributor
Author
Added. |
abhishek1508
approved these changes
Sep 22, 2022
Contributor
abhishek1508
left a comment
abhishek1508
left a comment
There was a problem hiding this comment.
LGTM!! The puck looks nice 😄
Zayankovsky
force-pushed
the
NAVAND-287-vz-notify-map-clicked
branch
from
d2d530b to
e2ba8df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #6313.