bump search sdk version to 1.0.0-beta.37#6436
Merged
Zayankovsky merged 1 commit intomainfrom Oct 4, 2022
Merged
Conversation
Zayankovsky
added
Android Auto
Zayankovsky
force-pushed
the
vz-fix-android-auto-search
branch
from
901b63c to
59f4a40
Compare
Codecov Report
@@ Coverage Diff @@
## main #6436 +/- ##
=========================================
Coverage 69.42% 69.42%
Complexity 4653 4653
=========================================
Files 697 697
Lines 27520 27520
Branches 3205 3205
=========================================
Hits 19107 19107
Misses 7169 7169
Partials 1244 1244 |
kmadsen
reviewed
Oct 4, 2022
| private val placesListOnMapManager = PlacesListOnMapManager(placesProvider) | ||
|
|
||
| init { | ||
| attachCreated(searchCarContext.carRouteRequest, searchCarContext.carPlaceSearch) |
Contributor
There was a problem hiding this comment.
the carRouteRequest is already registered here in the DefaultLifecycleObserver
Will you move this, trying to avoid @OptIn(ExperimentalPreviewMapboxNavigationAPI::class) wherever we can
Contributor
Author
There was a problem hiding this comment.
Oh, looks like it is not necessary then, I removed the commit. The issue was present in 0.12.0 release, but it is already fixed on the latest commit in main.
Zayankovsky
force-pushed
the
vz-fix-android-auto-search
branch
from
59f4a40 to
42965e6
Compare
Zayankovsky
changed the title
Zayankovsky
added
skip changelog
kmadsen
approved these changes
Oct 4, 2022
Zayankovsky
force-pushed
the
vz-fix-android-auto-search
branch
from
42965e6 to
97ca439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.