[Drop-In] Remove @Experimental annotation from drop in related files

[abhishek1508]

Description

The implementation covers

• removing @ExperimentalPreviewMapboxNavigationAPI annotation from all internal and public files related to libnavui-dropin module.
• removing @ExperimentalPreviewMapboxNavigationAPI from all new components that are exposed outside libnavui-dropin module. For ex: RouteLineComponent, RouteLineComponentContract, RecenterButtonComponent etc. It shouldn't be an issue removing the experimental annotation, since these components and their respective contracts are hosted inside internal package.
• adding@ExperimentalPreviewMapboxNavigationAPI to MapboxExtendableButton.updateStyles and it's usage across the SDK.
• not removing @ExperimentalPreviewMapboxNavigationAPI from any files related to ComponentInstaller and it's usage. ComponentInstaller could be subject to modifications and we need to play more with them before declaring them stable.

[codecov]

Codecov Report

Merging #6471 (c8ca9a4) into main (a45f7d4) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head c8ca9a4 differs from pull request most recent head 95f2c30. Consider uploading reports for the commit 95f2c30 to get more accurate results

@@             Coverage Diff              @@
##               main    #6471      +/-   ##
============================================
+ Coverage     70.26%   70.33%   +0.07%     
+ Complexity     4918     4907      -11     
============================================
  Files           722      717       -5     
  Lines         28044    27947      -97     
  Branches       3305     3295      -10     
============================================
- Hits          19705    19657      -48     
+ Misses         7064     7012      -52     
- Partials       1275     1278       +3     

Impacted Files	Coverage Δ
...mapbox/navigation/navigator/internal/TripStatus.kt	0.00% <0.00%> (-100.00%)	⬇️
...com/mapbox/navigation/core/history/HistoryFiles.kt	60.00% <0.00%> (-8.43%)	⬇️
...x/navigation/core/history/MapboxHistoryRecorder.kt	42.85% <0.00%> (-4.97%)	⬇️
...x/navigation/ui/maps/building/BuildingProcessor.kt	65.62% <0.00%> (-2.38%)	⬇️
...ava/com/mapbox/navigation/core/MapboxNavigation.kt	67.85% <0.00%> (-1.81%)	⬇️
...box/navigation/core/NavigationComponentProvider.kt	51.35% <0.00%> (-1.43%)	⬇️
...box/navigation/ui/voice/api/MapboxAudioGuidance.kt	79.68% <0.00%> (-0.32%)	⬇️
...om/mapbox/navigation/base/route/NavigationRoute.kt	51.92% <0.00%> (-0.24%)	⬇️
.../mapbox/navigation/route/internal/RouterWrapper.kt	80.35% <0.00%> (-0.12%)	⬇️
...n/dropin/navigationview/MapboxNavigationViewApi.kt	92.59% <0.00%> (-0.10%)	⬇️
... and 19 more

[tomaszrybakiewicz]

@abhishek1508 Why did you remove this comment?

[abhishek1508]

In the beginning all our classes were public and hence the need for documentation for all. Since we changed the relevant ones to internal, we did not remove the comments. Our code base has now become quite inconsistent as to some internal classes have descriptions vs the others don't. This was an attempt to bring consistency.

However I have put them back for the time being.

[tomaszrybakiewicz]

@abhishek1508 The changes that remove @Experimental annotation are great.
However, I have a couple of questions about some other changes:

• Why are we moving and modifying ComponentInstaller classes? I think these changes are outside the scope of this PR and should be done separately.
• Why are we removing class description comments?

[abhishek1508]

@abhishek1508 The changes that remove @Experimental annotation are great. However, I have a couple of questions about some other changes:

• Why are we moving and modifying ComponentInstaller classes? I think these changes are outside the scope of this PR and should be done separately.

Answered here

• Why are we removing class description comments?

Answered here

@tomaszrybakiewicz

[abhishek1508]

@tomaszrybakiewicz All suggestions have been applied. PTAL and let me know if any other changes are needed.

[tomaszrybakiewicz]

LGTM

[Zayankovsky]

It's weird that we now have mapboxNavigationForward and forwardMapboxNavigation with identical implementations. cc @kmadsen

[kmadsen]

Yeah, I had some direct messages with abhishek1508 about this. I really like the mapboxNavigationForward function in android auto. It is a little similar to requireMapboxNavigation

So the plan will be to delete the mapboxNavigationForward function in androidauto, in favor of forwardMapboxNavigation in the core-sdk. Sorry it's confusing to have them renamed, consequence of iteration.

But this is all intentional