[Drop-In UI] Fix issue with MapboxExtendableButton so it can be rendered in any shape possible.#6498
Merged
tomaszrybakiewicz merged 1 commit intomainfrom Oct 28, 2022
Conversation
tomaszrybakiewicz
added
the
UI
Codecov Report
@@ Coverage Diff @@
## main #6498 +/- ##
=========================================
Coverage 70.33% 70.33%
Complexity 4941 4941
=========================================
Files 724 724
Lines 28148 28148
Branches 3320 3320
=========================================
Hits 19798 19798
Misses 7074 7074
Partials 1276 1276 |
tomaszrybakiewicz
changed the title
MapboxExtendabluButton so it can be rendered in any shape possible.MapboxExtendableButton so it can be rendered in any shape possible.
tomaszrybakiewicz
changed the title
MapboxExtendableButton so it can be rendered in any shape possible.MapboxExtendableButton so it can be rendered in any shape possible.
3 tasks
tomaszrybakiewicz
force-pushed
the
NAVAND-793_tr_drop-in-fix-mapbox-extendable-button
branch
from
76de873 to
6557e8e
Compare
Contributor
Author
@korshaknn Yes. The buttons use
I've added an example to MapboxNavigationViewCustomizedActivity that shows how to do it. |
tomaszrybakiewicz
force-pushed
the
NAVAND-793_tr_drop-in-fix-mapbox-extendable-button
branch
from
ec21122 to
309b075
Compare
3 tasks
abhishek1508
approved these changes
Oct 27, 2022
Contributor
abhishek1508
left a comment
abhishek1508
left a comment
There was a problem hiding this comment.
Requested a minor change. Otherwise, LGTM
tomaszrybakiewicz
force-pushed
the
NAVAND-793_tr_drop-in-fix-mapbox-extendable-button
branch
2 times, most recently
from
c8c19a0 to
fbf15d6
Compare
…inders. Removed MapboxExtendableButtonParams. Removed all ViewStyleCustomization.***ButtonParams fields Added ViewStyleCustomization.***ButtonStyle fields for each button Added ViewOptionsCustomization.showCompassActionButton Updated all ***ButtonBinder's to apply margins when installing button views. Re-gen Metalava file. Updated qa-test-app to showcase introduced changes. Fixed CompassButtonComponent unit test Fixed mapbox_ic_compass drawable to point north. Moved qa-test-app styles used by MapboxNavigationViewCustomizedActivity to a separate file. Added compass style override example to qa-test-app. CHANGELOG entry Updated how end marigins are applied to Route Preview and Start Nav Buttons Update libnavui-dropin/src/main/res/layout/mapbox_info_panel_header_route_preview_layout.xml Co-authored-by: Abhishek Kejriwal <abhishek.kejriwal@mapbox.com>
tomaszrybakiewicz
force-pushed
the
NAVAND-793_tr_drop-in-fix-mapbox-extendable-button
branch
from
fbf15d6 to
19705b9
Compare
tomaszrybakiewicz
deleted the
NAVAND-793_tr_drop-in-fix-mapbox-extendable-button
branch
tomaszrybakiewicz
added a commit
that referenced
this pull request
Nov 1, 2022
…inders. (#6498) Removed MapboxExtendableButtonParams. Removed all ViewStyleCustomization.***ButtonParams fields Added ViewStyleCustomization.***ButtonStyle fields for each button Added ViewOptionsCustomization.showCompassActionButton Updated all ***ButtonBinder's to apply margins when installing button views. Re-gen Metalava file. Updated qa-test-app to showcase introduced changes. Fixed CompassButtonComponent unit test Fixed mapbox_ic_compass drawable to point north. Moved qa-test-app styles used by MapboxNavigationViewCustomizedActivity to a separate file. Added compass style override example to qa-test-app. CHANGELOG entry Updated how end marigins are applied to Route Preview and Start Nav Buttons
abhishek1508
pushed a commit
that referenced
this pull request
Nov 1, 2022
…inders. (#6498) Removed MapboxExtendableButtonParams. Removed all ViewStyleCustomization.***ButtonParams fields Added ViewStyleCustomization.***ButtonStyle fields for each button Added ViewOptionsCustomization.showCompassActionButton Updated all ***ButtonBinder's to apply margins when installing button views. Re-gen Metalava file. Updated qa-test-app to showcase introduced changes. Fixed CompassButtonComponent unit test Fixed mapbox_ic_compass drawable to point north. Moved qa-test-app styles used by MapboxNavigationViewCustomizedActivity to a separate file. Added compass style override example to qa-test-app. CHANGELOG entry Updated how end marigins are applied to Route Preview and Start Nav Buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes NAVAND-793
Description
Changes:
MapboxExtendableButtonre-create logic from UIComponents to UIBinders.MapboxExtendableButtonParams.ViewStyleCustomization.***ButtonParamsfieldsViewStyleCustomization.***ButtonStylefield for each buttonViewOptionsCustomization.showCompassActionButton***ButtonBinder's to apply button spacing as margins when installing button views.Todos