Merged
Conversation
kmadsen
added
the
Android Auto
Codecov Report
@@ Coverage Diff @@
## main #6530 +/- ##
=========================================
Coverage 70.47% 70.47%
Complexity 5033 5033
=========================================
Files 729 729
Lines 28404 28404
Branches 3383 3383
=========================================
Hits 20019 20019
Misses 7113 7113
Partials 1272 1272 |
kmadsen
force-pushed
the
NAVAND-841-add-MapboxCarMapLoader
branch
4 times, most recently
from
4e19151 to
d0b391d
Compare
Zayankovsky
reviewed
Nov 2, 2022
kmadsen
force-pushed
the
NAVAND-841-add-MapboxCarMapLoader
branch
2 times, most recently
from
a1b4f66 to
e97d5dc
Compare
Zayankovsky
approved these changes
Nov 2, 2022
Zayankovsky
reviewed
Nov 2, 2022
kmadsen
force-pushed
the
NAVAND-841-add-MapboxCarMapLoader
branch
2 times, most recently
from
ad9713f to
7ec141f
Compare
kmadsen
force-pushed
the
NAVAND-841-add-MapboxCarMapLoader
branch
from
7ec141f to
10a4c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moving this class to the sdk because it is essentially copy pasted in all our solutions. This also removes a step for setting up the sdk.
Similar to the CompassWidget, it is optional to use so it is not part of the MapboxCarContext. But i'm considering making this enabled by default, and then you disable it in order to provide your own style loader. That way the behavior can be supported through MapboxCarContext and MapboxCarOptions