Backport Copilot feature to release-v2.8#6791
Merged
Guardiola31337 merged 18 commits intorelease-v2.8from Jan 9, 2023
Merged
Conversation
… from NN 115.0.1 as it was introduced as part of NN v119 add multiple history recorders support (needed for copilot) (#6509)
…available anymore causing building issues
…e owner to support android auto and remove android x lifecycle process dependency not necessary anymore (#6609)
…led to include deferred events as part of the current history file session (#6655)
… owner based on if mapbox navigation app is set up or not respectively to support both use cases in which mapbox navigation app is or is not integrated from the client side and add is copilot initialized check to prevent issues if apis are misused (#6690)
Codecov Report
@@ Coverage Diff @@
## release-v2.8 #6791 +/- ##
==================================================
+ Coverage 68.99% 69.38% +0.38%
- Complexity 4540 4675 +135
==================================================
Files 682 707 +25
Lines 27144 27770 +626
Branches 3178 3223 +45
==================================================
+ Hits 18728 19267 +539
- Misses 7191 7257 +66
- Partials 1225 1246 +21
|
dzinad
reviewed
Jan 6, 2023
| } | ||
|
|
||
| public final class AlternativeRouteMetadata { | ||
| method public int getAlternativeId(); |
Contributor
There was a problem hiding this comment.
Wondering where this came from. Is this Copilot related?
Contributor
Author
There was a problem hiding this comment.
This is definitely not coming from Copilot. Wondering if it's a merge conflict issue or a Metalava one. Will check. Thanks for flagging!
Contributor
Author
There was a problem hiding this comment.
I see that removing both entries and running $> make core-check-api is still ✅
Will remove them. I believe the issue is #6257
dzinad
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
release-v2.8