Make the location switch to map matching faster#6906
Merged
Conversation
ChangelogFeaturesBug fixes and improvements
Known issues
|
Zayankovsky
approved these changes
Jan 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #6906 +/- ##
=========================================
Coverage 72.74% 72.74%
Complexity 5614 5614
=========================================
Files 785 785
Lines 30310 30311 +1
Branches 3578 3578
=========================================
+ Hits 22049 22050 +1
Misses 6828 6828
Partials 1433 1433
|
dzinad
reviewed
Jan 31, 2023
| replayRouteSession = null | ||
| replayHistorySession.onDetached(mapboxNavigation) | ||
| mapboxNavigation.startTripSession() | ||
| mapboxNavigation.resetTripSession { } |
Contributor
There was a problem hiding this comment.
It's not blocking. Is it expected?
Contributor
Author
There was a problem hiding this comment.
blocking the upstream flow could provide better support for rapid type changes. this change was a quick fix for an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ReplayRouteSession will resetTripSession when the route is cleared.
The ReplayHistorySession will restTripSession when the history file changes.
But there is no logic that exists when you go from a replay mode, into a regular gps following map matching mode. This pull request adds that, so that it will be faster to switch from replay to device map matching.