Skip to content

Comments

Adopt Transifex for localizations#203

Merged
frederoni merged 8 commits intomasterfrom
fred-transifex
May 4, 2017
Merged

Adopt Transifex for localizations#203
frederoni merged 8 commits intomasterfrom
fred-transifex

Conversation

@frederoni
Copy link
Contributor

Fixes #168
This PR adopts Transifex for pulling in localizations.
New languages added: sv, vi
Update languages: zh-Hans

@1ec5 👀

@frederoni frederoni requested a review from 1ec5 May 3, 2017 09:46
Copy link
Contributor Author

@frederoni frederoni May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 Any idea why I have to replace this comment manually with the one in Base-language after pulling in from Transifex and converted to UTF-8? (It only happens when I force using the -f flag)
screenshot 2017-05-03 13 40 22

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you used Xcode’s File inspector to convert the file from UTF-16 to UTF-8, it left a BOM at the beginning of the file. Xcode’s strings file copying action, which converts the file from text plist format to binary plist format, only recognizes the BOM when the file is encoded in UTF-16. The workaround is either to cut and paste the file’s contents back into the file in Xcode or to use another text editor (or a tool like iconv).

.tx/config Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this project only holds iOS code, let’s move lang_map up to the [main] section.

@1ec5
Copy link
Contributor

1ec5 commented May 3, 2017

Catalan is also ready now.

@1ec5
Copy link
Contributor

1ec5 commented May 3, 2017

In the iOS SDK project, we’ve added stub Localizable.strings files to the iosapp target so that we can see what the SDK localizations look like while running iosapp. To keep the translation “cost” down, we opted not to make the entire application localizable, since iosapp is rarely seen by developers let alone users. For this project, however, the sample applications’ storyboards include only a few strings, so we might as well make the storyboards localizable as well.

[main]
host = https://www.transifex.com
lang_map = pt_BR: pt-BR, pt_PT: pt-PT, zh_CN: zh-Hans, zh_TW: zh-Hant
minimum_perc = 80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #106 lands first, we’ll want to add Navigation.storyboard to the resources and give it a minimum_perc much lower than 80%, since most of the strings are “DO NOT TRANSLATE”.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, it hit first.

.tx/config Outdated
source_lang = en

[mapbox-navigation-ios.navigationstrings]
file_filter = MapboxNavigation/Resources/<lang>.lproj/Localizable.strings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this file to be called Navigation.strings, not Localizable.strings.

.tx/config Outdated

[mapbox-navigation-ios.navigationstrings]
file_filter = MapboxNavigation/Resources/<lang>.lproj/Localizable.strings
source_file = MapboxNavigation/Resources/Base.lproj/Localizable.strings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to pull from en.lproj/Navigation.strings.

@frederoni frederoni merged commit 9cfb608 into master May 4, 2017
@bsudekum bsudekum deleted the fred-transifex branch May 4, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants