Change reroute radius threshold calculation#228
Merged
Conversation
Contributor
Author
|
In f2c9e69, I changed when we snap. Previously we:
Now:
|
0e1bb3e to
273b7e6
Compare
273b7e6 to
c0cea02
Compare
Closed
Contributor
Author
|
@frederoni @1ec5 after testing this for a bit, I think it's makes for a good addition. 👍 on merging? |
1ec5
approved these changes
May 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had reports of constant rerouting on highways. Our current thinking that this is a combination of a few factors:
These combinations could produce a rerouting event since their
horizontalAccuracyis < 10m and theRouteControllerUserLocationSnappingDistanceis `10m. This produces a radius threshold of only 20m.This change now looks at the maximum value between
RouteControllerMaximumDistanceBeforeRecalculating(50m) and thehorizontalAccuracy+RouteControllerUserLocationSnappingDistance(10m).Here are the situations that will change:
/cc @mapbox/navigation @danpat @willwhite