Conversation
1ec5
reviewed
May 23, 2017
| fallbackText = speechString(notification: notification, markUpWithSSML: false) | ||
|
|
||
| // If the user is merging onto a highway, an announcement to merge is a bit excessive | ||
| guard let upComingStep = routeProgress.currentLegProgress.upComingStep, !(routeProgress.currentLegProgress.currentStep.maneuverType == .takeOnRamp && upComingStep.maneuverType == .merge && routeProgress.currentLegProgress.alertUserLevel == .high) else { |
Contributor
There was a problem hiding this comment.
If there's no upcoming step, this code also bails. Is that intended?
Contributor
This PR doesn't check that there's only one possible maneuver. Does it need to? |
1ec5
approved these changes
May 23, 2017
|
|
||
| // If the user is merging onto a highway, an announcement to merge is a bit excessive | ||
| guard let upComingStep = routeProgress.currentLegProgress.upComingStep, !(routeProgress.currentLegProgress.currentStep.maneuverType == .takeOnRamp && upComingStep.maneuverType == .merge && routeProgress.currentLegProgress.alertUserLevel == .high) else { | ||
| if let upComingStep = routeProgress.currentLegProgress.upComingStep, (routeProgress.currentLegProgress.currentStep.maneuverType == .takeOnRamp && upComingStep.maneuverType == .merge && routeProgress.currentLegProgress.alertUserLevel == .high) { |
Contributor
There was a problem hiding this comment.
Nit: the parentheses are no longer needed here.
wishtrip-dev
pushed a commit
to wishtrip-dev/mapbox-navigation-ios
that referenced
this pull request
Feb 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is only a single option and it is to merge onto a highway, a
highalert becomes redundant and is noise. The removes the high alert when the upcoming maneuver is merge and the current maneuver istakeOnRamp./cc @ericrwolfe