Conversation
bsudekum
commented
Jun 9, 2017
| if timeToTravel > 1 { | ||
| let newCoordinate = coordinate(at: speed, fromStartOf: [location.coordinate, nextLocation.coordinate]) | ||
| let newLocation = SimulatedLocation(coordinate: newCoordinate!, | ||
| guard let newCoordinate = coordinate(at: speed, fromStartOf: [location.coordinate, nextLocation.coordinate]) else { return processedLocations } |
Contributor
Author
There was a problem hiding this comment.
Not really sure if this is the right thing to return early here.
Contributor
There was a problem hiding this comment.
Calling return in the guard statement here will break out of the for loop prematurely. Seems like it might be better to continue instead of returning early.
ericrwolfe
suggested changes
Jun 9, 2017
| if timeToTravel > 1 { | ||
| let newCoordinate = coordinate(at: speed, fromStartOf: [location.coordinate, nextLocation.coordinate]) | ||
| let newLocation = SimulatedLocation(coordinate: newCoordinate!, | ||
| guard let newCoordinate = coordinate(at: speed, fromStartOf: [location.coordinate, nextLocation.coordinate]) else { return processedLocations } |
Contributor
There was a problem hiding this comment.
Calling return in the guard statement here will break out of the for loop prematurely. Seems like it might be better to continue instead of returning early.
Contributor
Author
|
@ericrwolfe fixed |
ericrwolfe
approved these changes
Jun 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldn't always assume that those coordinates are always there.
/cc @frederoni @ericrwolfe