Conversation
frederoni
force-pushed
the
fred-attribution-layout
branch
from
6e8e48a to
cd46d8f
Compare
bsudekum
reviewed
Jun 20, 2017
| var arrowCurrentStep: RouteStep? | ||
| var isInOverviewMode = false | ||
|
|
||
| let overviewContentInset = UIEdgeInsets(top: 65, left: 15, bottom: 55, right: 15) |
Contributor
There was a problem hiding this comment.
Overview mode required some extra padding on all sides to account for the marker height. How does it look right now?
Contributor
|
Looks good other than in this mode, two things:
|
Contributor
Author
|
@bsudekum good catch. The overview content insets have been reverted.
Here's another iOS 11 shot for demonstration purposes: |
bsudekum
approved these changes
Jun 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236
Besides moving the ornaments, this PR also changes the partially revealed height from 75% to 60% of the screen height.
@bsudekum 👀