Conversation
3dc0d78 to
1e6a7af
Compare
1ec5
left a comment
There was a problem hiding this comment.
With this refactoring, we can modify the podspec to split PollyVoiceController.swift into a subspec: #280 (comment).
We could further streamline the setup process: PollyVoiceController.swift could define a category method on NavigationViewController that sets up the voice controller. That would come at the cost of modularity, I suppose.
There was a problem hiding this comment.
This is a very vague name. Could we fold this into alertLevelDidChange(_:) and allow subclasses to override that method?
1e6a7af to
79c803a
Compare
|
Interesting idea about the category but less obvious to grasp and debug. We should add a new target for PollyVoiceController when we create the podspec to |
|
If we add a separate target, we'd have to add a separate podspec. Subspecs can't coexist with separate modules. |
Fixes #280
Split up voice controllers into RouteVoiceController and PollyVoiceController.
Replace AVSpeech with Polly:
@1ec5 @bsudekum 👀