Fix lifecycle issue when using storyboard#314
Merged
Conversation
1ec5
approved these changes
Jun 27, 2017
Contributor
There was a problem hiding this comment.
Good idea. Should we unset oldValue’s delegate too, just in case the developer swaps location managers?
frederoni
force-pushed
the
fred-fix-storyboard
branch
from
30393b1 to
d1cdab5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273
RouteController and delegates were unset when using the storyboard approach.
Also fixed so that SimulatedLocationManager bridges to Obj-C
@friedbunny 👀