Only suppress announcements on long first steps after reroute#395
Merged
Only suppress announcements on long first steps after reroute#395
Conversation
1ec5
approved these changes
Jul 18, 2017
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
We really need to rename these alert levels. The comment and the code are speaking two completely different languages…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #382
We got a lot of feedback that the lack of information after rerouting was troubling. Now, if the first step of the new reroute is short, alert the user of it. Otherwise when the step is long (greater than 0.5km) just let them continue.
/cc @willwhite @1ec5 @ericrwolfe @frederoni