Feedback UI

[frederoni]

Feedback UI

@bsudekum @ericrwolfe 👀

[bsudekum]

Would it be possible to split a non UI class out of this that lives in core? This would allow users who use MapboxCoreNavigation to piggy back off the feedback UI class, set appropriate variables and then create their own UI.

[ericrwolfe]

@bsudekum you can use the following 3 methods on RouteController to hook in feedback events to your own feedback UI:

mapbox-navigation-ios/MapboxCoreNavigation/RouteController.swift

Lines 248 to 269 in 12a51b4

	public func recordFeedback(type: FeedbackType, description: String?) {
	enqueueFeedbackEvent(type: type, description: description)
	}
	/**
	Update the last recorded feedback event, for example if you have a custom feedback UI that lets a user elaborate on an issue.
	*/
	public func updateLastFeedback(type: FeedbackType, description: String?) {
	if let lastFeedback = outstandingFeedbackEvents.filter({$0 is FeedbackEvent}).last {
	lastFeedback.eventDictionary["feedbackType"] = type.rawValue
	lastFeedback.eventDictionary["description"] = description
	}
	}
	/**
	Discard the last recorded feedback event, for example if you have a custom feedback UI and the user cancelled feedback.
	*/
	public func cancelLastFeedback(type: FeedbackType, description: String?) {
	if let lastFeedback = outstandingFeedbackEvents.filter({$0 is FeedbackEvent}).last, let index = outstandingFeedbackEvents.index(of: lastFeedback) {
	outstandingFeedbackEvents.remove(at: index)
	}
	}

. Is that what you mean?

[bsudekum]

👍 , @ericrwolfe yeah that looks. I was thinking there was more we could abstract out of here into core but it doesn't look like it.

[bsudekum]

Holding on illustrations

[bsudekum]

Going to need some docs here.

[bsudekum]

Looks good other than doc addition.

[ericrwolfe]

@frederoni added some docs and made feedback events easier to update + cancel. Also cancelled autodismissal on selection and moved dismissal logic to the parent controller so that it's possible to show a confirmation UI afterwards.

@frederoni can you increase the label size as large as possible without wrapping, change the text color to black or near black for added contrast, and change the following label names (keeping at a max of 11 chars)?

• Turn not allowed ➡️ Not allowed
• Road closed ➡️ Closure
• Routing error ➡️ Confusing
• Other ➡️ Other issue

@willwhite I'm still not sure I feel the route issue choices list is the right balance between clear and simple though comprehensive. Do you think the list covers the majority of issues you've been seeing? Part of me wants to replace Hazard with Closure for now to give space for another route issue option such as Wrong (instruction or route) to complement Confusing. We can bring Hazard back later once we have a better idea of the issues drivers are facing.