Skip to content

Comments

Remove redundant arrival notification#414

Merged
bsudekum merged 1 commit intomasterfrom
1ec5-double-arrival
Jul 24, 2017
Merged

Remove redundant arrival notification#414
bsudekum merged 1 commit intomasterfrom
1ec5-double-arrival

Conversation

@1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jul 23, 2017

NavigationViewControllerDelegate.navigationViewController(_:didArriveAt:) is getting called twice in a row. This change removes the redundant call.

/cc @bsudekum

@1ec5 1ec5 added the bug Something isn’t working label Jul 23, 2017
@1ec5 1ec5 self-assigned this Jul 23, 2017
@1ec5 1ec5 requested a review from bsudekum July 23, 2017 04:37
Copy link
Contributor

@bsudekum bsudekum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 so where is NavigationViewControllerDelegate.navigationViewController(_:didArriveAt:) getting called now?

Copy link
Contributor

@bsudekum bsudekum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...

@bsudekum bsudekum merged commit df11e10 into master Jul 24, 2017
@bsudekum bsudekum deleted the 1ec5-double-arrival branch July 24, 2017 20:04
@ericrwolfe ericrwolfe modified the milestone: v0.6.0-2 Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn’t working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants