Conversation
bsudekum
reviewed
Aug 14, 2017
| sessionState.pastLocations.push(location) | ||
|
|
||
| guard location.isQualified else { | ||
| delegate?.routeController?(self, didDiscard: location) |
Contributor
|
Looks good. My only qualm visually is the spinner- it makes me think we're waiting on something. What do you think about hiding it for this action? |
Contributor
Author
|
It could continue spinning for as long as we discard locations and then we hide the status view when we get the first qualified location? |
Contributor
|
@frederoni I'm suggesting hiding the spinner completely while the gps signal is poor. Update: retracting my previous comment. This UI element needs to be extensible for future actions that are added to the status view. Stacking might become busy, but let's test it and see how it works. |
bsudekum
reviewed
Aug 14, 2017
| optional func routeController(_ routeController: RouteController, willRerouteFrom location: CLLocation) | ||
|
|
||
| @objc(routeController:didDiscardLocation:) | ||
| optional func routeController(_ routeController: RouteController, didDiscard location: CLLocation) |
Contributor
There was a problem hiding this comment.
We'll need some documentation for this new delegate method.
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new delegate that informs the user about a discarded (non-qualified) location and a corresponding UI. Also simplified the animations by removing all manual constraint animations.
@bsudekum 👀