Skip to content

Comments

Restore < to format string#527

Merged
bsudekum merged 1 commit intomasterfrom
1ec5-less-than-457
Aug 23, 2017
Merged

Restore < to format string#527
bsudekum merged 1 commit intomasterfrom
1ec5-less-than-457

Conversation

@1ec5
Copy link
Contributor

@1ec5 1ec5 commented Aug 23, 2017

Undid an unexplained change to a format string that changed the string’s meaning. A couple localizations had already localized the “<” to something locally appropriate, while others had removed the “<” in keeping with the base string.

/ref #457 (comment)
/cc @frederoni @bsudekum

@1ec5 1ec5 added the bug Something isn’t working label Aug 23, 2017
@1ec5 1ec5 self-assigned this Aug 23, 2017
@1ec5 1ec5 requested a review from frederoni August 23, 2017 00:35
@1ec5 1ec5 added this to the v0.7.0-3 milestone Aug 23, 2017
@1ec5 1ec5 mentioned this pull request Aug 23, 2017
6 tasks
@bsudekum bsudekum merged commit 6c751d9 into master Aug 23, 2017
@bsudekum bsudekum deleted the 1ec5-less-than-457 branch August 23, 2017 00:55
@frederoni
Copy link
Contributor

frederoni commented Aug 23, 2017

The motivation for removing < from the UI was aesthetic and using a language not only engineers speak. Most navigation UIs seems to use 1 as the minimum for time remaining. I'd prefer that and perhaps spell out "less than".
/cc @ericrwolfe

@1ec5
Copy link
Contributor Author

1ec5 commented Aug 23, 2017

I’m not sure how the arithmetic less-than sign is any more engineering-centric than an abbreviation like “mi” or “ft”. But I’m in favor of spelling out “less than” if we also spell out “miles” and “feet”.

Otherwise, as I mentioned in #457 (comment), if there’s no need for a “<” or “less than” (or the localized equivalent), then there shouldn’t be a format string in the first place.

@ericrwolfe ericrwolfe modified the milestones: v0.7.0-3, v0.7.0-4 Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn’t working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants