Conversation
bsudekum
approved these changes
Aug 23, 2017
Contributor
|
The motivation for removing |
Contributor
Author
|
I’m not sure how the arithmetic less-than sign is any more engineering-centric than an abbreviation like “mi” or “ft”. But I’m in favor of spelling out “less than” if we also spell out “miles” and “feet”. Otherwise, as I mentioned in #457 (comment), if there’s no need for a “<” or “less than” (or the localized equivalent), then there shouldn’t be a format string in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undid an unexplained change to a format string that changed the string’s meaning. A couple localizations had already localized the “<” to something locally appropriate, while others had removed the “<” in keeping with the base string.
/ref #457 (comment)
/cc @frederoni @bsudekum