Conversation
There was a problem hiding this comment.
This sounds like the name of a property that returns a value without side-effects, which isn’t the case. How about updateETA()?
There was a problem hiding this comment.
Why “info”? updateETATimer is fine.
There was a problem hiding this comment.
Can this be an optional instead of an implicitly unwrapped optional? That way the code is explicit about the case where it isn’t set (before viewWillAppear(_:)).
There was a problem hiding this comment.
Don't we still need to refresh this after a reroute?
|
@1ec5 @ericrwolfe fixed. |
There was a problem hiding this comment.
This timer will leak the whole class unless we invalidate it in deinit or viewDidUnload().
|
Fixed |
bsudekum
force-pushed
the
update-eta-time
branch
from
5605ae0 to
ac846b6
Compare
| super.viewWillDisappear(animated) | ||
|
|
||
| UIApplication.shared.isIdleTimerDisabled = false | ||
| updateETATimer = nil |
There was a problem hiding this comment.
invalidate() the timer before nilling it out.
|
@1ec5 fixed. |
3 participants
Closes: #594
When the user is not moving, we should still be able to give them accurate info about their trip.
This also removes a few functions that existed just to call another function.
/cc @1ec5 @frederoni @ericrwolfe