Conversation
Some strings files had been misplaced due to swapped resource slugs on Transifex. These files have been moved to their correct locations, and all strings files have been updated based on Transifex.
Merged
frederoni
approved these changes
Sep 16, 2017
Contributor
frederoni
left a comment
frederoni
left a comment
There was a problem hiding this comment.
Good catch. Should we also pull in the latest from Transifex? There are updates in es,ca,sv, and vi.
Contributor
Author
I ran |
Contributor
Saw quite a few changes with just |
Contributor
Author
You’re right, looks like a number of translations got stuck and only force-pulling worked. No idea why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some strings files had been misplaced due to swapped resource slugs on Transifex. As a result, the speech format strings and the feedback UI both had fewer working translations than they should’ve had. I corrected the resource slugs, moved the misplaced files to their correct locations, and updated all strings files based on Transifex.
txskipped some translations of Localizable.strings in MapboxNavigation because recent additions to the source file have pushed the translated rate below 80%./ref #505 (review)
/cc @frederoni @bsudekum