LocationEngineProvider provides incorrect 'best' LocationEngine

[codeversed]

When using an Android device that does not have Google Play Services installed, LocationEngineProvider obtains the wrong LocationEngine. If the application includes dependencies for com.google.android.gms.location.LocationServices, a false positive returns LocationEngine.Type.GOOGLE_PLAY_SERVICES.

Steps to reproduce

1. Use a device that does not have Google Play Services (or the play store) installed. Example: DJI Crystal Sky
2. Use the latest MapBox SDK's LocationEngineProvider to obtainBestLocationEngineAvailable()
3. Observe the LocationEngine provided is LocationEngine.Type.GOOGLE_PLAY_SERVICES which can not be used if the device does not have Google Play Services installed

Expected behavior

The LocationEngineProvider should provide LocationEngine with LocationEngine.Type.ANDROID

Actual behavior

The LocationEngine provides LocationEngine.Type.GOOGLE_PLAY_SERVICES

Configuration

DJI Crystal Sky running (Android API level 22), no Play Services

mapbox-android-sdk:6.6.1
mapbox-android-plugin-locationlayer:0.11.0

My Workaround

private LocationEngine obtainBestLocationEngineAvailable(Context context) {
    if (PlayServicesUtils.checkPlayServices(context)) {
        return new LocationEngineProvider(context).obtainBestLocationEngineAvailable();
    } else {
        return new LocationEngineProvider(context)
                .obtainLocationEngineBy(LocationEngine.Type.ANDROID);
    }
}

/**
 * Check the device to make sure it has the Google Play Services APK. If
 * it doesn't, display a dialog that allows users to download the APK from
 * the Google Play Store or enable it in the device's system settings.
 */
public static boolean checkPlayServices(Context context) {
    GoogleApiAvailability apiAvailability = GoogleApiAvailability.getInstance();
    int resultCode = apiAvailability.isGooglePlayServicesAvailable(context);
    return resultCode == ConnectionResult.SUCCESS;
}

This will ensure that the device has Google Play Services, which is required for LocationEngine.Type.GOOGLE_PLAY_SERVICES aka Google's FusedLocationProvider

[andrlee]

@codeversed this issue has been fixed in new version of android-core-1.1.0: https://github.com/mapbox/mapbox-events-android/blob/fbab184b6891ad7c4088b52c839bdc07eceb2670/liblocation/src/main/java/com/mapbox/android/core/location/LocationEngineProvider.java#L44

[codeversed]

@andrlee Awesome, good to know! Is this only in snap-shots right now?

[LukasPaczos]

The fixed version is included in the Maps SDK 7.0.0-alpha.3 pre-release if you'd like to test it out. It also includes the LocationComponent and allows to drop the LocationLayerPlugin dependency entirely.

Thanks for reaching out @codeversed, closing as resolved.