Skip to content

Invalidate the widget when plugin is toggled #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasPaczos merged 1 commit into from
Aug 13, 2019
Merged

Invalidate the widget when plugin is toggled #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugin-scalebar/src/main/java/com/mapbox/pluginscalebar/ScaleBarPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ public void setEnabled(boolean enabled) {
scaleBarWidget.setVisibility(enabled ? View.VISIBLE : View.GONE);
if (enabled) {
mapboxMap.addOnCameraMoveListener(cameraMoveListener);
invalidateScaleBar();
} else {
mapboxMap.removeOnCameraMoveListener(cameraMoveListener);
}
Expand Down
14 changes: 13 additions & 1 deletion plugin-scalebar/src/test/java/com/mapbox/pluginscalebar/ScaleBarPluginTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import com.mapbox.mapboxsdk.maps.MapView
import com.mapbox.mapboxsdk.maps.MapboxMap
import com.mapbox.mapboxsdk.maps.Projection
import io.mockk.MockKAnnotations
import io.mockk.clearAllMocks
import io.mockk.every
import io.mockk.impl.annotations.MockK
import io.mockk.verify
Expand Down Expand Up @@ -102,4 +101,17 @@ class ScaleBarPluginTest {
verify { scaleBarWidget.visibility = View.VISIBLE }
verify(exactly = 1) { mapboxMap.addOnCameraMoveListener(scaleBarPlugin.cameraMoveListener) }
}

@Test
fun toggled_invalidateWidget() {
val scaleBarPlugin = ScaleBarPlugin(mapView, mapboxMap)
scaleBarPlugin.create(scaleBarOptions)
verify(exactly = 1) { mapboxMap.cameraPosition }
verify(exactly = 1) { scaleBarWidget.setDistancePerPixel(100_000.0) }
scaleBarPlugin.isEnabled = false
scaleBarPlugin.isEnabled = true

verify(exactly = 2) { mapboxMap.cameraPosition }
verify(exactly = 2) { scaleBarWidget.setDistancePerPixel(100_000.0) }
}
}