Conversation
cammace
added
the
ready for review
danesfeder
approved these changes
Mar 30, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Looks good, just one typo (I think). Thanks @cammace
| * attributes while leaving the rest alone and maintaining their default behavior. | ||
| * | ||
| * @param context your activites context used to acquire the style resource | ||
| * @param context your activates context used to acquire the style resource |
Contributor
There was a problem hiding this comment.
I think you meant to fix to activities here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #368
Adds new attributes and fixes private style.