Use json features instead of layer properties setters #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
the
location-layer-plugin
tobrun
reviewed
Apr 16, 2018
Member
tobrun
left a comment
tobrun
left a comment
There was a problem hiding this comment.
Changes are looking good! how is performance? seeing less of those Attempt to remove non-JNI local reference logs?
Contributor
Author
|
@tobrun Performance feels alright, didn't compare FPS against old implementation but that's a good point, I'll do that. |
LukasPaczos
force-pushed
the
362-use-json-features
branch
from
0843f34 to
493a969
Compare
danesfeder
approved these changes
Apr 19, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Looks great - thanks for walking me through the improvements here @LukasPaczos
11 tasks
md-cherepanov
pushed a commit
to md-cherepanov/mapbox-plugins-android
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #362 and closes #413.