Generic geometry #777
Merged
Generic geometry #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-generic-geometry
branch
from
9513907 to
2d76836
Compare
LukasPaczos
reviewed
Nov 22, 2018
Contributor
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
One note, otherwise 🚀
tobrun
force-pushed
the
tvn-generic-geometry
branch
from
2d76836 to
5ff54bf
Compare
LukasPaczos
reviewed
Nov 22, 2018
plugin-annotation/src/main/java/com/mapbox/mapboxsdk/plugins/annotation/Annotation.java
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-generic-geometry
branch
from
5ff54bf to
b75a175
Compare
LukasPaczos
approved these changes
Nov 28, 2018
| } | ||
|
|
||
| void setGeometry(Geometry geometry) { | ||
| public void setGeometry(T geometry) { |
Contributor
There was a problem hiding this comment.
Since we are making set/get public, javadoc entry would be great.
tobrun
force-pushed
the
tvn-generic-geometry
branch
from
b75a175 to
966f874
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses generics to apply to correct geometry type for an annotation.