Added removePolicy and listPolicies methods to PolicyPipeline to allow for easier modification and inspection of the pipeline's policies.
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/fetchRequest.ts
Outdated
| this.policies.push(policy); | ||
| } | ||
|
|
||
| removePolicy(policy: FetchPolicy) { |
Contributor
There was a problem hiding this comment.
you could have a polymorphic string | FetchPolicy as a parameter for remove, but having two methods is ok
zmofei
force-pushed
the
improve_fetch_request
branch
from
622fb34 to
b1f2566
Compare
mattpodwysocki
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
PolicyPipelineAPI insrc/utils/fetchRequest.tsto improve clarity and flexibility when managing fetch policies. The main changes include renaming the method for adding policies, introducing new methods for removing and listing policies, and updating usages to match the new method names. Additionally, the pipeline instance is now exported for broader access.API improvements for policy management:
usetousePolicyin thePolicyPipelineclass to make its purpose clearer.removePolicyandlistPoliciesmethods toPolicyPipelineto allow for easier modification and inspection of the pipeline's policies.Usage and export updates:
usePolicymethod instead of the oldusemethod.systemFetchPipelinefor use elsewhere in the codebase.