Merged
Conversation
zmofei
reviewed
Nov 4, 2025
Member
zmofei
left a comment
zmofei
left a comment
There was a problem hiding this comment.
Thanks for add the feedback tools, the changes looks good to me, but please change the tool's name to match other tools.
| export class FeedbackListTool extends MapboxApiBasedTool< | ||
| typeof FeedbackListInputSchema | ||
| > { | ||
| name = 'feedback_list_tool'; |
Member
There was a problem hiding this comment.
To match other tools' schema, could we change this to list_feedback_tool
Suggested change
| name = 'feedback_list_tool'; | |
| name = 'list_feedback_tool'; |
Contributor
Author
There was a problem hiding this comment.
changed tools naming convention to match mcp-devkit-server instead mcp-server tools
| export class FeedbackGetTool extends MapboxApiBasedTool< | ||
| typeof FeedbackGetInputSchema | ||
| > { | ||
| name = 'feedback_get_tool'; |
Member
There was a problem hiding this comment.
Suggested change
| name = 'feedback_get_tool'; | |
| name = 'get_feedback_tool'; |
zmofei
approved these changes
Nov 5, 2025
Member
zmofei
left a comment
zmofei
left a comment
There was a problem hiding this comment.
Really appreciate the improvements to the devkit MCP — this PR looks solid. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented the Feedback API tool for the Mapbox MCP Server, providing access to the Mapbox Feedback API for retrieving user feedback items. The tool supports both listing feedback items with comprehensive filtering options and retrieving individual feedback items by ID.
The tool requires
user-feedback:readscope on the Mapbox access token.Testing
Run locally via
npm run inspect:devand tested the tools (FeedbackGetTool and FeedbackListTool)Tests:
Checklist