refactor: remove point_in_polygon_tool in favor of points_within_polygon_tool#181
Merged
mattpodwysocki merged 23 commits intomainfrom Apr 14, 2026
Merged
Conversation
Implements MCP server icons at the correct architectural level (server initialization) instead of at the tool level. Adds both light and dark theme variants of the Mapbox logo using base64-encoded SVG data URIs. - Add mapbox-logo-black.svg for light theme backgrounds - Add mapbox-logo-white.svg for dark theme backgrounds - Update server initialization to include icons array with theme property - Use 800x180 SVG logos embedded as base64 data URIs This replaces the previous incorrect approach of adding icons to individual tools, which was not aligned with the MCP specification. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updates the MCP SDK from 1.25.1 to 1.25.2 and recreates the output validation patch for the new version. The patch continues to convert strict output schema validation errors to warnings, allowing tools to gracefully handle schema mismatches. Changes: - Update @modelcontextprotocol/sdk from ^1.25.1 to ^1.25.2 - Recreate SDK patch for version 1.25.2 - Remove obsolete 1.25.1 patch file - All 397 tests pass with new SDK version Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…gon_tool points_within_polygon_tool fully covers the single-point case by passing a one-element points array. Having two tools for the same concept creates unnecessary model confusion when choosing between them. - Remove PointInPolygonTool and all associated files - Remove pointInPolygon pre-configured instance from tools barrel - Update points_within_polygon_tool description to make clear it handles single points as well as batches - Remove point_in_polygon_tool references from annotations test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
version_tool was removed in 0.11.0 in favor of the mapbox://version resource. These entries in the offline tools arrays were dead code — filtering nothing — since the tool no longer exists in the registry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
|
Replaces stale point_in_polygon_tool reference flagged in PR review. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Fixed in 7d05433 — replaced |
Valiunia
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
points_within_polygon_toolfully covers the single-point case — pass a one-elementpointsarray and the result is equivalent. Having two tools for the same concept creates unnecessary ambiguity for the model when choosing between them.Why remove
point_in_polygon_tool?Pros of removing:
points_within_polygon_toolalready handles both single and batch cases cleanly@mapbox/mcp-server/toolsCons / risks:
point_in_polygon_toolby name or importingPointInPolygonTool— migration is mechanical but requiredThe trade-off strongly favors removal: the single-point case is already idiomatic in the batch API, the migration path is trivial, and the benefit of a cleaner, unambiguous tool surface is significant.
Changes:
PointInPolygonTooland all associated files (input schema, output schema, tests)pointInPolygonpre-configured instance from the@mapbox/mcp-server/toolsbarrelpoints_within_polygon_tooldescription to make clear it handles single points as well as batchespoint_in_polygon_toolandversion_toolentries fromannotations.test.ts(both no longer exist in the registry — dead code)Migration: Replace any use of
point_in_polygon_toolwithpoints_within_polygon_toolusing a single-elementpointsarray:{ "points": [{ "longitude": -122.4, "latitude": 37.8 }], "polygon": [...] }Test plan
npm test— 706 tests pass (719 − 13 removed point_in_polygon tests)🤖 Generated with Claude Code