fix copy button ssr bug#203
Merged
chriswhong merged 1 commit intomainfrom Jan 19, 2023
Merged
Conversation
tristen
approved these changes
Jan 19, 2023
Member
tristen
left a comment
tristen
left a comment
There was a problem hiding this comment.
Sounds like a reasonable change to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug we encountered while attempting to upgrade
dr-uito use the latest version ofmr-ui.The
CopyButtoncomponent makes use ofclipboard.jswhich expects to run in the browser and referencesdocument. When attempting to build thedr-uidocs, batfish attempts to create static pages and the build fails while trying to render static content forCodeSnippet, which usesCopyButton.CodeSnippet actually does a check for
isCopySupported()before attempting to renderCopyButton, so this is an ideal place to also check whether the code is running in a browser.With this change, if there is no browser
CopyButton.isCopySupported()returnsfalse,CopyButtonis never rendered, and SSR can proceed without issue.