Conversation
Contributor
|
This works as intended, fixing the problem described in https://github.com/mapbox/api-fonts/issues/407. It is currently deployed on staging via https://github.com/mapbox/api-fonts/pull/441, passed all automated tests along the way and some manual tests by me and @meganluisa. Would be happy if this was published as a non-development version so we can finally close that issue! 🙂 |
rafaykh90
commented
Feb 20, 2023
axrj
approved these changes
Feb 23, 2023
axrj
left a comment
axrj
left a comment
There was a problem hiding this comment.
lgtm. Thanks.
Please cleanup the package version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes where artifacts appear on top of the fonts
