fix: add_bool now calls through buffer_customization.#140
Merged
kkaefer merged 1 commit intoMay 22, 2026
Merged
Conversation
Collaborator
|
Thanks. This looks good to me, but CI didn't succeed due to an unrelated issue that needs fixing first. |
Member
|
@mikaellindemann thanks for your submission! could you please rebase this on the latest changes in master to get CI to pass? |
Collaborator
|
@mikaellindemann Can you please rebase instead of merging master into your branch? |
mikaellindemann
force-pushed
the
fix/add_bool_using_buffer_customization
branch
from
902e29f to
6983bf2
Compare
Contributor
Author
|
I think I managed to do so now. Thank you very much! 🙏 |
joto
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #139 I cannot use a buffer of a non-char element type (e.g.
std::vector<std::byte>).By calling through the existing
buffer_customization<TBuffer>::push_backfunction, this use-case should be supported.fixes #139.