Support export default (Typescript related)#62
Merged
mourner merged 1 commit intomapbox:masterfrom Oct 6, 2017
Merged
Conversation
mourner
approved these changes
Oct 6, 2017
Contributor
Author
|
@mourner 👍 Do you mind if I send send more PR's to all your MANY other repos? |
Member
|
@DenisCarriere yeah, no harm from a change like this :) |
Contributor
Author
|
@mourner Sounds good! Should I bump the |
Member
|
@DenisCarriere no, it's better for me to do |
Contributor
Author
|
Oh gotcha! 👍 (maybe I should do the same when I publish my repos 😄 ) |
Contributor
Author
|
Expect ~5-10 PR's |
This was referenced Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/tinyqueue
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/rbush-knn
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/kdbush
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/earcut
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/delaunator
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/linematch
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/lineclip
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/simplify-js
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mourner/kdbush
that referenced
this pull request
Oct 6, 2017
This was referenced Oct 6, 2017
mourner
pushed a commit
to mourner/tinyqueue
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mourner/simplify-js
that referenced
this pull request
Oct 6, 2017
DenisCarriere
added a commit
to DenisCarriere/tiny-sdf
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mapbox/delaunator
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mapbox/lineclip
that referenced
this pull request
Oct 6, 2017
8 tasks
Contributor
Author
|
@mourner Should be done now for the Thanks for the quick merges 👍 |
mourner
pushed a commit
to mourner/rbush-knn
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mapbox/tiny-sdf
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mapbox/cheap-ruler
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mapbox/linematch
that referenced
this pull request
Oct 6, 2017
mourner
pushed a commit
to mapbox/earcut
that referenced
this pull request
Oct 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support export default (Typescript related)
Mainly used for Typescript support, other bundlers like Rollup/Babel use some other "magic" to support default exports.
Same thing was done for concaveman & polylabel (PR mapbox/polylabel#10):
An update to the Typescript definition has already been made to reflect this change: DefinitelyTyped/DefinitelyTyped#20348
Rollup "magic" (import default)
Gets compile to:
Rollup "no-magic" (import without default)
Gets compile to:
CC: @alex3165 @mourner