This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Enable setting the host to other than 127.0.0.1 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmactough
force-pushed
the
enable-local-backend
branch
from
9892d46 to
d62fe9e
Compare
Unblocks being able to run in a docker container
danmactough
force-pushed
the
enable-local-backend
branch
from
d62fe9e to
eb010d7
Compare
Contributor
Author
|
The failing test is not at all related to the changes in this PR and isn't even supposed to be running in that Travis job (it runs in a different Travis job -- that succeeds 🤷♂). Should I ignore it? |
kepta
approved these changes
Nov 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks being able to run
underreact start --host 0.0.0.0inside a docker container, such as you may want to do if you have multiple applications (services, frontends, etc.) you want to run locally.Per the DevServer docs, we need to be able to listen on
0.0.0.0to be reachable outside the docker container (in other containers, from your browser on the host machine etc.).