This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Update svg-react-transformer loader to fix svgs missing viewBox #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
🙄 Same bogus test failures that we saw in #101 (comment) |
davidtheclark
approved these changes
Dec 3, 2019
Contributor
davidtheclark
left a comment
davidtheclark
left a comment
There was a problem hiding this comment.
👍
Could you an issue about these test failures?
Contributor
Author
Done #103 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svg-react-transformerv2.0.0 would sometimes cause build/start to fail due to a missingviewBoxsvg attribute. This bumpssvg-react-transformerto^2.0.1to pick up the fix.