Conversation
pozdnyakov
reviewed
Feb 20, 2023
pozdnyakov
reviewed
Mar 7, 2023
pozdnyakov
left a comment
pozdnyakov
left a comment
There was a problem hiding this comment.
looks good overall, could you add a unit test?
alexshalamov
reviewed
Mar 7, 2023
alexshalamov
reviewed
Mar 7, 2023
alexshalamov
reviewed
Mar 7, 2023
zmiao
force-pushed
the
zmiao-duplicate-feature-keys
branch
7 times, most recently
from
6f886c0 to
f385d9f
Compare
zmiao
force-pushed
the
zmiao-duplicate-feature-keys
branch
from
f385d9f to
0b027b2
Compare
Contributor
Author
|
Somehow the rebase history gets messed up, so I just add the commits one by one, I will squash merge this PR. |
pozdnyakov
approved these changes
Mar 9, 2023
alexshalamov
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not fail for cases when there are multiple tag ids mapping to the same feature key in one layer, instead issue a warning message if the message function is enabled.