-
Notifications
You must be signed in to change notification settings - Fork 6
N-API #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
N-API #90
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
698fa0f
Initial implementation useing `N-API` via `node-addon-api`
artemp f2c8360
check CallbackInfo index is valid + format/tidy
artemp f1765fd
attempting to fix .travis.yml (/home/travis/.travis/job_stages: line …
artemp 7aabb89
Perhaps more generic approach to obtaining 'node-addon-api' include path
artemp 23eeb11
Merge branch 'master' into n-api
artemp 18e5359
remove `<uv,h>`
artemp 4efb356
Simplify `CallbackError` signature
artemp ae290da
use `As<Napi::Object>` consistently
artemp 93806a9
remove redundant conversion
artemp 4f50896
Minimise internal type conversions by passing `Napi::Buffer<char>` an…
artemp 86e4ab1
Merge branch 'master' into n-api
artemp 0694dbe
Merge branch 'master' into n-api
artemp 4ab12a5
bring back node-pre-gyp :)
artemp b28077a
4x faster polygon decoding
c4daa7b
clang-format
artemp 44b8ef2
initialise `ring_` member variable in initialiser list
artemp 6a77f2e
attempting to fix `codecov`
artemp 09aef2e
update pip
artemp be4c9e8
Revert "update pip"
artemp a7395ad
Revert "attempting to fix `codecov`"
artemp 8cef8a6
codecov : add more dirs for ignore
artemp 49cd191
stderr $PATH
artemp 7ef8a80
remove relative path from $PATH
artemp ed85265
fix prev commit
artemp 463faa7
cleanup
artemp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # 0.2.0 | ||
|
|
||
| - Upgrade to use N-API and remove nan/node-pre-gyp deps | ||
|
|
||
| # 0.1.3 | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| ignore: | ||
| - "test" | ||
| - "test" | ||
| - "mason_packages" | ||
| - "node_modules" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artemp what's the need for slicing the include instead of using
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mapsam this is the only way I found that works for me. The above expansion has too many quotes. Pls, suggest workaround, it's probably lack JS knowledge on my behalf.