Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
698fa0f
Initial implementation useing `N-API` via `node-addon-api`
artemp Oct 25, 2018
f2c8360
check CallbackInfo index is valid + format/tidy
artemp Oct 25, 2018
f1765fd
attempting to fix .travis.yml (/home/travis/.travis/job_stages: line …
artemp Oct 18, 2018
7aabb89
Perhaps more generic approach to obtaining 'node-addon-api' include path
artemp Oct 25, 2018
23eeb11
Merge branch 'master' into n-api
artemp Oct 29, 2018
18e5359
remove `<uv,h>`
artemp Oct 30, 2018
4efb356
Simplify `CallbackError` signature
artemp Oct 31, 2018
ae290da
use `As<Napi::Object>` consistently
artemp Nov 19, 2018
93806a9
remove redundant conversion
artemp Nov 19, 2018
4f50896
Minimise internal type conversions by passing `Napi::Buffer<char>` an…
artemp Nov 19, 2018
86e4ab1
Merge branch 'master' into n-api
artemp Dec 3, 2018
0694dbe
Merge branch 'master' into n-api
artemp Jan 23, 2019
4ab12a5
bring back node-pre-gyp :)
artemp Jan 23, 2019
b28077a
4x faster polygon decoding
Dec 2, 2018
c4daa7b
clang-format
artemp Jan 23, 2019
44b8ef2
initialise `ring_` member variable in initialiser list
artemp Jan 23, 2019
6a77f2e
attempting to fix `codecov`
artemp Jan 23, 2019
09aef2e
update pip
artemp Jan 23, 2019
be4c9e8
Revert "update pip"
artemp Jan 23, 2019
a7395ad
Revert "attempting to fix `codecov`"
artemp Jan 23, 2019
8cef8a6
codecov : add more dirs for ignore
artemp Jan 24, 2019
49cd191
stderr $PATH
artemp Jan 25, 2019
7ef8a80
remove relative path from $PATH
artemp Jan 25, 2019
ed85265
fix prev commit
artemp Jan 25, 2019
463faa7
cleanup
artemp Jan 25, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ matrix:
# Overrides `script` to publish coverage data to codecov
script:
- export PATH=$(pwd)/mason_packages/.link/bin/:${PATH}
- PATH=`echo $PATH | sed -e 's/:\.\/node_modules\/\.bin//'` # remove relative path ^^
- which llvm-cov
- curl -S -f https://codecov.io/bash -o codecov
- chmod +x codecov
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 0.2.0

- Upgrade to use N-API and remove nan/node-pre-gyp deps

# 0.1.3

Expand Down
7 changes: 4 additions & 3 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
['AR', '<(module_root_dir)/mason_packages/.link/bin/llvm-ar'],
['NM', '<(module_root_dir)/mason_packages/.link/bin/llvm-nm']
],
'includes': [ 'common.gypi' ], # brings in a default set of options that are inherited from gyp
'includes': [ 'common.gypi'], # brings in a default set of options that are inherited from gyp
'variables': { # custom variables we use specific to this file
'error_on_warnings%':'true', # can be overriden by a command line variable because of the % sign using "WERROR" (defined in Makefile)
# Use this variable to silence warnings from mason dependencies and from NAN
# Use this variable to silence warnings from mason dependencies
# It's a variable to make easy to pass to
# cflags (linux) and xcode (mac)
'system_includes': [
"-isystem <(module_root_dir)/<!(node -e \"require('nan')\")",
"-isystem <!@(node -p \"require('node-addon-api').include.slice(1,-1)\")",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artemp what's the need for slicing the include instead of using

"<!@(node -p \"require('node-addon-api').include\")"

?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mapsam this is the only way I found that works for me. The above expansion has too many quotes. Pls, suggest workaround, it's probably lack JS knowledge on my behalf.

"-isystem <(module_root_dir)/mason_packages/.link/include/"
],
# Flags we pass to the compiler to ensure the compiler
Expand Down Expand Up @@ -88,6 +88,7 @@
}
}]
],
#'include_dirs' : ["<!@(node -p \"require('node-addon-api').include\")"],
'cflags_cc': [
'<@(system_includes)',
'<@(compiler_checks)'
Expand Down
4 changes: 3 additions & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
ignore:
- "test"
- "test"
- "mason_packages"
- "node_modules"
Loading