Name generation algorithm misses "AS" for "American Samoa"

[ebowman]

I think looking up AS should find American Samoa?

[rijnb]

American Samoa is only known as US-AS or USA-AS. Why would it need to be recognized without the US or USA prefix?

[ebowman]

This just seems wrong (this is the java version being used from the scala console):

scala> Territory.fromString("AS").getParentTerritory
res8: com.mapcode.Territory = IND

scala> Territory.fromString("US-AS").getParentTerritory
res9: com.mapcode.Territory = null

So Assam is declared as:

val IN_AS = Territory(286, "Assam", Some(IND))

which means that I can get to it by either asking for "IN-AS" or "AS".

American Samoa is declared as:

val ASM = Territory(27, "American Samoa", None, Seq("US-AS", "USA-AS"), Seq("Samoa, American"))

...so it feels like I should be able to get to it via "US-AS" or "AS".

I claim that asking for "AS" and passing no parent should return ASM, not IN_AS, since I can get IN_AS by searching for "AS" and passing IND as a parent.

[rijnb]

The official ISO code "AS" (http://nl.wikipedia.org/wiki/ISO_3166-2:AS) indeed stands for American Samoa. This behavior should be changed.

[rijnb]

Same goes for "BR" which should return "BRA" and not "IN-BR".

[rijnb]

Changed the Javadoc to explain the actual correct behavior (which is AS stands for IN-AS and BR stands for IN-BR).