Skip to content

Update StatsViewModel.kt #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mapgie merged 1 commit into from
May 31, 2026
+8 −2
Merged

Update StatsViewModel.kt #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/src/main/java/com/mapgie/goflo/ui/screens/stats/StatsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,26 +325,32 @@ class StatsViewModel(
reloadChart()
}

private fun recalcChartTypeForPair(
private fun recalcChartTypeForPair(
cat1: TrackingCategory,
cat2: TrackingCategory?,
currentType: ChartType
): ChartType {
val hiddenForTwoCats = cat2 != null &&
(currentType == ChartType.TRENDS || currentType == ChartType.TIME_SERIES)

if (!hiddenForTwoCats && isValidChartType(currentType, cat1, cat2)) return currentType
return when {

val newChartType = when {
cat1.isNumeric && cat2?.isNumeric == true -> ChartType.SCATTER
cat2 != null -> ChartType.DUAL_TIME_SERIES
cat1.isNumeric -> ChartType.TIME_SCATTER
else -> ChartType.TRENDS
} // <-- The missing brace!

preferencesStore?.let { store ->
viewModelScope.launch {
store.setStatsCategory1Id(-1L)
store.setStatsCategory2Id(-1L)
store.setStatsChartType("")
}
}

return newChartType
}

fun setTimeRange(range: TimeRange) {
Expand Down
Loading