makemkv: Check for both makemkv and makemkvcon before building#31
Merged
makemkv: Check for both makemkv and makemkvcon before building#31
Conversation
The previous idempotency checks only tested for one binary (makemkvcon in debian, makemkv in pop_os), so a partial install could cause a full rebuild on the next run. Check for both makemkv and makemkvcon; skip the build only if both are present. Also update pop_os version from 1.17.6 to 1.18.3 to match the current release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
debian/install-makemkv(symlinked fromubuntu/): Check for bothmakemkvandmakemkvconbefore running the build. Previously only checkedmakemkvcon, so a partial install would trigger a full rebuild on re-run.pop_os/install-makemkv: Same idempotency fix (was only checkingmakemkv), plus bump version from1.17.6to1.18.3to match the current release.