Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 24, 2025

Bumps @maplibre/maplibre-gl-style-spec from 23.1.0 to 23.2.1.

Release notes

Sourced from @​maplibre/maplibre-gl-style-spec's releases.

v23.2.1

https://github.com/maplibre/maplibre-gl-style-spec Changes since MapLibre Style Spec v23.2.0:

🐞 Bug fixes

  • Validate that numberArray and colorArray values are non-empty (#1094)

v23.2.0

https://github.com/maplibre/maplibre-gl-style-spec Changes since MapLibre Style Spec v23.1.0:

✨ Features and improvements

  • glyphs is now optional even if a symbol layer specifies text-field; if it is unset, text-font is interpreted as a fallback font list (#1068)
  • hillshade layer now supports multiple methods, and the multidirectional method supports array values for illumination properties (#1088)
  • Add global-state expression and state root property (#1044).

🐞 Bug fixes

  • Fix RuntimeError class, make it inherited from Error (#983)
  • Validate that layers array items are objects instead of throwing an error if not (#1026)
  • Multiple fixes related to validating and parsing of strings containing object prototype keys
    • Fix validate_object crashing when object prototype keys used in style's objects (#1028)
    • Fix validate_color crashing when object prototype keys used as color strings (#1036)
    • Fix color coercion in expressions (e.g. to_color) producing invalid colors when object prototype keys used as color strings (#1036)
Changelog

Sourced from @​maplibre/maplibre-gl-style-spec's changelog.

23.2.1

🐞 Bug fixes

  • Validate that numberArray and colorArray values are non-empty (#1094)

23.2.0

✨ Features and improvements

  • glyphs is now optional even if a symbol layer specifies text-field; if it is unset, text-font is interpreted as a fallback font list (#1068)
  • hillshade layer now supports multiple methods, and the multidirectional method supports array values for illumination properties (#1088)
  • Add global-state expression and state root property (#1044).

🐞 Bug fixes

  • Fix RuntimeError class, make it inherited from Error (#983)
  • Validate that layers array items are objects instead of throwing an error if not (#1026)
  • Multiple fixes related to validating and parsing of strings containing object prototype keys
    • Fix validate_object crashing when object prototype keys used in style's objects (#1028)
    • Fix validate_color crashing when object prototype keys used as color strings (#1036)
    • Fix color coercion in expressions (e.g. to_color) producing invalid colors when object prototype keys used as color strings (#1036)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@maplibre/maplibre-gl-style-spec](https://github.com/maplibre/maplibre-gl-style-spec) from 23.1.0 to 23.2.1.
- [Release notes](https://github.com/maplibre/maplibre-gl-style-spec/releases)
- [Changelog](https://github.com/maplibre/maplibre-style-spec/blob/main/CHANGELOG.md)
- [Commits](maplibre/maplibre-style-spec@v23.1.0...v23.2.1)

---
updated-dependencies:
- dependency-name: "@maplibre/maplibre-gl-style-spec"
  dependency-version: 23.2.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 24, 2025
@github-actions github-actions bot enabled auto-merge (squash) April 24, 2025 08:20
@HarelM
Copy link
Collaborator

HarelM commented Apr 24, 2025

@NathanMOlson, does this mean that there's a problem with the types generated by this package? I'm not sure I fully understand why this is failing just from looking at the run log...

@HarelM
Copy link
Collaborator

HarelM commented Apr 24, 2025

I'm wondering if part of the code generation should be done in the style spec package instead of here... What do you think?

@NathanMOlson
Copy link
Collaborator

@HarelM At least #5756 needs to be merged to bump to 23.2.X. But since #5768 is almost ready, I think we can jump straight to that.

I don't have an opinion on where the code generation should go, I'm not very familiar with that part of the code.

@HarelM
Copy link
Collaborator

HarelM commented Apr 24, 2025

Fair enough...

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 24, 2025

Looks like @maplibre/maplibre-gl-style-spec is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Apr 24, 2025
auto-merge was automatically disabled April 24, 2025 18:11

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/maplibre/maplibre-gl-style-spec-23.2.1 branch April 24, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants