Skip to content

Do not publish Cargo.lock to creates.io#1759

Closed
nyurik wants to merge 1 commit intomaplibre:mainfrom
nyurik:exclude-lock
Closed

Do not publish Cargo.lock to creates.io#1759
nyurik wants to merge 1 commit intomaplibre:mainfrom
nyurik:exclude-lock

Conversation

@nyurik
Copy link
Member

@nyurik nyurik commented Mar 22, 2025

No description provided.

@nyurik nyurik requested a review from CommanderStorm March 22, 2025 04:46
Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this effectively auto-update transitive dependencys.
Am a bit torn.

  • on the pro side: we don't need to do a release if something is found there
  • on the con side: one of these could break us and we might not know...

=> Lets try this and see where it leads

@nyurik
Copy link
Member Author

nyurik commented Mar 24, 2025

Heh, I am not certain about my own PR here tbh.

  • cargo install uses it only if --locked flag is passed - see docs
  • The libs.rs owner's dashboard shows a weird warning, which might actually be ok to ignore?
    image

@nyurik nyurik marked this pull request as draft April 7, 2025 03:34
@CommanderStorm
Copy link
Member

I think at this point we can close the pr. We can obviously reopen if you want to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants