Prepare for newer semver versions, bring index._ and index.js in sync#154
Merged
artemp merged 2 commits intomapnik:gh-pagesfrom Feb 13, 2020
Merged
Prepare for newer semver versions, bring index._ and index.js in sync#154artemp merged 2 commits intomapnik:gh-pagesfrom
artemp merged 2 commits intomapnik:gh-pagesfrom
Conversation
It seems that newer versions (>= v7.0.0) of the semver module have dropped support for calling it as semver(<version>), so switching to semver.parse(<version>) makes the code ready for a future upgrade to a more current version of the semver module.
This brings the versionRefs list in sync with the versions list again.
Contributor
Author
|
The suggested change in this PR is using an approach that is similar to one in the patch in the slightly newer issue #155, which is already used in the Debian package of |
Closed
Contributor
Author
|
Thanks :)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that newer versions (>= v7.0.0) of
semverhave dropped support for calling it assemver(<version>)while version^5.1.0, that is currently referenced inpackage.json, seems to supportsemver.parse(<version>)already, and thatindex.jsis not in sync withindex._anymore. This pull request should fix these two issues.