Publish two versions of windows binaries#757
Merged
springmeyer merged 2 commits intomasterfrom Apr 18, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 42 42
Lines 8810 8810
=======================================
Hits 8478 8478
Misses 332 332Continue to review full report at Codecov.
|
Member
Author
|
Merging this now. Will not republish binaries since @flippmoke already fixed this problem manually for v3.6.0. Merging this will protect us from the problem next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently only support vs2015 per https://github.com/mapnik/node-mapnik#windows-specific. A common convention with node-pre-gyp modules is to allow users to pass
--toolset=v140to opt-into binaries built with vs2015. Because node-mapnik only supports vs2015 we provide binaries for bothnpm install(no custom flag) andnpm install --toolset=v140. This keeps back compatibility with node-mapnik versions pre v3.6.0.Background at #756.