Conversation
…ttempting to read an area of zero width or height from an image in a vector tile resulting in an exception. Added a new test case to cover this case
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 42 42
Lines 8810 8810
=======================================
Hits 8478 8478
Misses 332 332Continue to review full report at Codecov.
|
springmeyer
reviewed
May 2, 2017
| Updated for a fix associated with mapnik-vector-tile where images could be requested that would have a width or height of zero resulting | ||
| in exceptions. | ||
|
|
||
| - Updated to mapnik-vector-tile@1.3.0 |
springmeyer
approved these changes
May 2, 2017
Member
|
@flippmoke - I presume the next step here is to revisit this after the changes to mapnik core? mapnik/mapnik#3672 |
Member
Author
|
@springmeyer yes, the changes here will be tweaked slightly once we have an official mapnik core release. |
artemp
approved these changes
Jun 2, 2017
…ed with this, updated tests for changes in mapnik vector tile due to more changes around rasters in vector tile layers
Member
Author
|
Waiting on binaries to be built for Mapnik core on windows and then hopefully we are good to merge this and start release process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated for a bug associated with mapnik-vector-tile. Initial commit points to a branch on mapnik-vector-tile, eventually will point to released version.
/cc @springmeyer for review.