Add new slot `derived_from` by cthoyt · Pull Request #548 · mapping-commons/sssom

cthoyt · 2026-05-23T07:11:26Z

Resolves #537

This PR adds a new field derived_from that enables mapping inference (e.g., via chaining, inversion) to refer back to the mappings from which it was derived.

This was motivated by needs from the NFDI use case, and also would enable nearly full subsumption of the SeMRA data model by the SSSOM data model.

It's been a few weeks since I posted the issue outlining this proposal and got some feedback on slack, so I thought it was time to make a concrete contribution.

docs/ have been added/updated if necessary (added inference.md)
make test has been run locally
tests have been added/updated (if applicable)
CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

provide a full, working and valid example in examples/
provide a link to the related GitHub issue in the see_also field of the linkml model
provide a link to a valid example in the see_also field of the linkml model
update the "Model changes across versions" (in src/docs/spec-models.md) accordingly
run SSSOM-Py test suite against the updated model

Implementations

gouttegd

Mostly looks good to me, but before this can be merged, either ts4nfdi/mapping-sameness-identifier#2 must be resolved or the PR must be amended to remove the bit about the appropriate CURIE/URI prefix for encoding MSIs as CURIEs being “left to the curators”.

cthoyt · 2026-05-24T13:12:51Z

@gouttegd thanks for the feedback. I agree that the introduction of MSIs here is problematic because of current unresolved discussions about MSI, so opted to remove references to it in the description.

I also switched to using example.com dummy URI prefixes in the examples

gouttegd

Looks good to me.

cthoyt · 2026-05-25T07:58:22Z

@matentzn ready for your final review

matentzn

Agree in principle with all this, but some quick fixes and RFCs

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

cthoyt · 2026-05-26T08:42:34Z

@matentzn @gouttegd ready for re-review

cthoyt · 2026-05-26T08:49:08Z

sorry nico, I deleted a comment about fixing the word CURIEs in the text that was resolved already but seemed to be hanging for some reason (github bug?)

gouttegd

A few last details, but otherwise still good.

matentzn

Some nits but basically done

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

matentzn

Great work! Thank you!

cthoyt marked this pull request as ready for review May 23, 2026 07:28

cthoyt requested review from gouttegd and matentzn and removed request for gouttegd May 23, 2026 07:51

cthoyt changed the title ~~Add derived from~~ Add new slot derived_from May 23, 2026

gouttegd reviewed May 23, 2026

View reviewed changes

Comment thread examples/schema/derived_from.sssom.tsv

gouttegd mentioned this pull request May 23, 2026

Add support for derived_from gouttegd/sssom-java#19

Merged

Add derived_from field

4e5d541

cthoyt force-pushed the add-derived-from branch from 812e09a to 4e5d541 Compare May 24, 2026 12:48

cthoyt added 8 commits May 24, 2026 14:52

Fix descriptions of mappings

fcbf056

Fix spurious whitespace

d93e27c

Update derived_from.sssom.tsv

77007f7

Remove text about how to encode CURIE/URI prefix

701d28e

Remove recommendation to use MSI in description

31f7cbb

Update sssom_schema.yaml

0b7adbf

Update inference.md

33795ca

Use example.org dummy URI

cb34aeb

Update inference.md

9fb8dcb

gouttegd reviewed May 24, 2026

View reviewed changes

Comment thread src/sssom_schema/schema/sssom_schema.yaml Outdated

Update sssom_schema.yaml

5ef24ec

gouttegd previously approved these changes May 25, 2026

View reviewed changes

cthoyt enabled auto-merge (squash) May 25, 2026 07:57

matentzn reviewed May 25, 2026

View reviewed changes

Update src/docs/inference.md

780e106

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

cthoyt dismissed gouttegd’s stale review via 780e106 May 25, 2026 17:29

cthoyt and others added 2 commits May 25, 2026 19:29

Update src/docs/inference.md

c0130ae

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

Update src/sssom_schema/schema/sssom_schema.yaml

c9337bf

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

cthoyt requested a review from gouttegd May 26, 2026 08:42

cthoyt added 2 commits May 26, 2026 10:47

Update inference.md

f039c50

Update inference.md

7093151

mapping-commons deleted a comment from matentzn May 26, 2026

cthoyt added 2 commits May 26, 2026 10:49

Update inference.md

9140247

Update inference.md

b91b8ec

gouttegd requested changes May 26, 2026

View reviewed changes

Comment thread src/docs/inference.md Outdated

Comment thread src/docs/inference.md Outdated

Comment thread src/sssom_schema/schema/sssom_schema.yaml Outdated

Updates based on Damien's comments

ece1535

cthoyt requested a review from gouttegd May 26, 2026 09:54

gouttegd previously approved these changes May 26, 2026

View reviewed changes

cthoyt enabled auto-merge (squash) May 26, 2026 10:12

matentzn requested changes May 26, 2026

View reviewed changes

Update src/docs/inference.md

2d9a45f

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

cthoyt dismissed gouttegd’s stale review via 2d9a45f May 26, 2026 13:12

cthoyt and others added 6 commits May 26, 2026 15:12

Update src/docs/inference.md

a28d899

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

Update src/docs/inference.md

082a974

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

Update src/docs/inference.md

788319d

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

Update cas CURIEs and labels

c555652

Reformat

78cd6c2

Update src/docs/inference.md

df41749

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

cthoyt requested review from gouttegd and matentzn May 26, 2026 13:16

matentzn approved these changes May 26, 2026

View reviewed changes

gouttegd approved these changes May 26, 2026

View reviewed changes

cthoyt merged commit f087f5e into master May 26, 2026
3 checks passed

cthoyt deleted the add-derived-from branch May 26, 2026 13:25

This was referenced May 28, 2026

Trace how one mapping was derived from a( set of o)nther? #91

Closed

Distinguish core mappings from metadata and introduce core_mapping_id #361

Closed

Conversation

cthoyt commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementations

Uh oh!

gouttegd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cthoyt commented May 24, 2026

Uh oh!

Uh oh!

gouttegd left a comment

Choose a reason for hiding this comment

Uh oh!

cthoyt commented May 25, 2026

Uh oh!

matentzn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cthoyt commented May 26, 2026

Uh oh!

cthoyt commented May 26, 2026

Uh oh!

gouttegd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matentzn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matentzn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cthoyt commented May 23, 2026 •

edited

Loading