Skip to content

Search text#502

Merged
rwood-97 merged 8 commits intomainfrom
search_text
Sep 12, 2024
Merged

Search text#502
rwood-97 merged 8 commits intomainfrom
search_text

Conversation

@rwood-97
Copy link
Copy Markdown
Collaborator

@rwood-97 rwood-97 commented Sep 12, 2024

Summary

This PR adds a search search_preds() method into MapReader to allow users to seach in their spotted text.

Fixes #

Describe your changes

  • Adds search_preds method
  • Adds show_search_results method
  • Adds save_search_results_to_geojson method (if georeferenced)
  • DeepSoloRunner and MapTextRunner now both inherit from RecRunner to avoid duplicate code

TODO:

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 125 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/spot_text/rec_runner_base.py 0.00% 119 Missing ⚠️
mapreader/spot_text/deepsolo_runner.py 0.00% 3 Missing ⚠️
mapreader/spot_text/maptext_runner.py 0.00% 3 Missing ⚠️
Flag Coverage Δ
unittests 68.38% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/spot_text/dptext_detr_runner.py 8.69% <ø> (ø)
mapreader/spot_text/runner_base.py 0.00% <ø> (ø)
mapreader/spot_text/deepsolo_runner.py 12.06% <0.00%> (+5.52%) ⬆️
mapreader/spot_text/maptext_runner.py 11.66% <0.00%> (+5.24%) ⬆️
mapreader/spot_text/rec_runner_base.py 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants