Skip to content

Isambard AI#551

Closed
rwood-97 wants to merge 6 commits intomaps-as-data:mainfrom
owhere:isambard
Closed

Isambard AI#551
rwood-97 wants to merge 6 commits intomaps-as-data:mainfrom
owhere:isambard

Conversation

@rwood-97
Copy link
Copy Markdown
Collaborator

@rwood-97 rwood-97 commented Feb 2, 2025

Summary

Add podman-hpc instructions for running MapReader on Isambard AI

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

Copy link
Copy Markdown
Collaborator Author

@rwood-97 rwood-97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

A couple comments after starting using the container (I got it working with podman-hpc build too).
I'm happy to implement these changes if you need

Comment thread container/README.md
Comment thread container/README.md
Comment thread container/mapreader-3.5.3.log
Comment thread container/mapreader-build-nid001040.log
Comment thread container/requirements.txt
Comment thread container/Dockerfile
Comment thread container/Dockerfile
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 78.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rwood-97
Copy link
Copy Markdown
Collaborator Author

I've created #552 to implement these changes.

@rwood-97 rwood-97 closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants