Skip to content

Integration of IIIF downloading into MapReader#554

Merged
rwood-97 merged 16 commits intomainfrom
piffle
Mar 25, 2025
Merged

Integration of IIIF downloading into MapReader#554
rwood-97 merged 16 commits intomainfrom
piffle

Conversation

@rwood-97
Copy link
Copy Markdown
Collaborator

@rwood-97 rwood-97 commented Feb 20, 2025

Summary

This PR integrates IIIF download into MapReader.
Addresses #77

Describe your changes

  • Add IIIF downloader class into MapReader with options of saving georeferenced IIIFs as geotiffs or non-georeferenced IIIFs as pngs.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 87.63251% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/download/iiif_downloader.py 83.64% 26 Missing ⚠️
tests/test_download/test_iiif_downloader.py 92.68% 9 Missing ⚠️
Flag Coverage Δ
unittests 79.44% <87.63%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/__init__.py 78.78% <100.00%> (+0.66%) ⬆️
setup.py 0.00% <ø> (ø)
tests/test_import.py 100.00% <ø> (ø)
tests/test_download/test_iiif_downloader.py 92.68% <92.68%> (ø)
mapreader/download/iiif_downloader.py 83.64% <83.64%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rwood-97 rwood-97 requested a review from kmcdono2 March 17, 2025 13:04
@rwood-97
Copy link
Copy Markdown
Collaborator Author

See also mapreader-examples for worked examples

Copy link
Copy Markdown
Collaborator

@kmcdono2 kmcdono2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very tiny edits to the text in my comments, otherwise fine!

Comment thread docs/source/using-mapreader/step-by-step-guide/1-download.rst Outdated
Comment thread docs/source/using-mapreader/step-by-step-guide/1-download.rst Outdated
Comment thread docs/source/using-mapreader/step-by-step-guide/1-download.rst Outdated
Comment thread docs/source/using-mapreader/step-by-step-guide/1-download.rst Outdated
Comment thread docs/source/using-mapreader/step-by-step-guide/1-download.rst Outdated
Comment thread mapreader/download/iiif_downloader.py Outdated
Comment thread mapreader/download/iiif_downloader.py
Comment thread mapreader/download/iiif_downloader.py Outdated
@kmcdono2 kmcdono2 added the download Issues related to the "Download" functionality label Mar 22, 2025
@rwood-97 rwood-97 merged commit e3b9838 into main Mar 25, 2025
10 of 11 checks passed
@rwood-97 rwood-97 deleted the piffle branch March 25, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

download Issues related to the "Download" functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants